Refactor auto extension resolution to not use k6deps and esbuild #5320

mstoykov · 2025-10-17T15:53:33Z

What?

Reimplement auto extension resolution without using esbuild or k6deps, but the internal methods that k6 uses to load modules.

Why?

This removes the need for a separate project to have the same way to parse and understand imports and also double parsing everything.

Also fixing a number of bugs coming from this and removes the maintaince burden to keep both projects align.

Checklist

I have performed a self-review of my code.
I have commented on my code, particularly in hard-to-understand areas.
I have added tests for my changes.
I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

I have added the correct milestone and labels to the PR.
I have updated the release notes: link
I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Based on #5240 and requires #5319 to have the same functionality as the same.

Fixes #5127
FIxes #5176
Fixes #5104
Closes #5102
Requirement for #5166 ( likely a future PR that refactors more of test_load.go)

Likely some updates to every other issue around automatic extension resolution as well.

mstoykov · 2025-10-21T10:49:29Z

This likely should get more tests, and either drop the launcher.go and the old way or to further make it possible to use the old resolution method ... for now at least.

But I would like some initial feedback and thoughts.

codebien · 2025-10-21T13:08:57Z

internal/cmd/launcher.go

+			constraints := string(match[idxUseConstraints])
+
+			if _, ok := deps[extension]; ok {
+				return deps, fmt.Errorf("already had a use directivce for %q", extension)


Suggested change

return deps, fmt.Errorf("already had a use directivce for %q", extension)

return deps, fmt.Errorf("already had a use directive for %q", extension)

Is this printed to the user? Can we make it a bit more user friendly? I guess if this appears out of nowhere the user is not getting it fast.

Please see it now.

internal/cmd/root.go

internal/cmd/test_load.go

pablochacin

I just gave a first pass and centered my comments on the structure of the code.

I find it unintuitive that we use an error for actually handling the missing dependencies. I would prefer if we could split the logic and use the error for reporting and let someone else (the root command?) to handle it by attempting binary provisioning.

internal/cmd/root.go

internal/cmd/test_load.go

Co-authored-by: Ivan <[email protected]>

internal/cmd/test_load.go

internal/cmd/root.go

Co-authored-by: Théo Crevon <[email protected]>

Everything has been changed

codebien · 2025-10-28T09:18:54Z

internal/cmd/test_load.go

+}
+
+// TODO(@mstoykov) potentially figure out some less "exceptionl workflow" solution
+type binaryIsNotSatisfyingDependenciesError struct {


Suggested change

type binaryIsNotSatisfyingDependenciesError struct {

type binaryUnsatisfiedDependenciesError struct {

I don't want to block the pull request for it. But maybe in a another pr we should now align the error with the latest change.

mstoykov added this to the v1.4.0 milestone Oct 17, 2025

mstoykov temporarily deployed to azure-trusted-signing October 17, 2025 15:59 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 17, 2025 16:09 — with GitHub Actions Inactive

mstoykov mentioned this pull request Oct 21, 2025

Preload modules from require calls #5319

Open

8 tasks

mstoykov force-pushed the basicNativeNativeBinaryProvisioning branch from 5c93d1d to d738041 Compare October 21, 2025 10:34

mstoykov temporarily deployed to azure-trusted-signing October 21, 2025 10:41 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 21, 2025 10:45 — with GitHub Actions Inactive

mstoykov marked this pull request as ready for review October 21, 2025 10:47

mstoykov requested a review from a team as a code owner October 21, 2025 10:47

mstoykov requested review from ankur22, codebien, oleiade and pablochacin and removed request for a team October 21, 2025 10:47

mstoykov mentioned this pull request Oct 21, 2025

Fix auto extension resolution breaking tests on windows #5206

Closed

8 tasks

mstoykov changed the title ~~Thread the running the binary up enough~~ Refactor auto extension resolution to not use k6deps and esbuild Oct 21, 2025

codebien reviewed Oct 21, 2025

View reviewed changes

internal/cmd/test_load.go Show resolved Hide resolved

Base automatically changed from allUnknownModulesDetection to master October 21, 2025 14:17

mstoykov force-pushed the basicNativeNativeBinaryProvisioning branch from 65afd95 to c8e52fa Compare October 22, 2025 08:56

mstoykov temporarily deployed to azure-trusted-signing October 22, 2025 09:04 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 22, 2025 09:06 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 22, 2025 09:17 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 22, 2025 09:19 — with GitHub Actions Inactive

pablochacin previously requested changes Oct 22, 2025

View reviewed changes

internal/cmd/root.go Outdated Show resolved Hide resolved

internal/cmd/root.go Outdated Show resolved Hide resolved

internal/cmd/test_load.go Show resolved Hide resolved

internal/cmd/test_load.go Outdated Show resolved Hide resolved

internal/cmd/test_load.go Outdated Show resolved Hide resolved

mstoykov and others added 6 commits October 24, 2025 18:53

Add dependancy type and fix errors and logs around loading files

a01ddac

do not set the launcher to nil

f024dad

Fix some corner case panics

49d1ae9

Fix #5327 for K6_OLD_RESOLUTION as well

9df44eb

Update internal/cmd/root.go

25378d3

Co-authored-by: Ivan <[email protected]>

propagate exit codes from subprocess

ca4a183

mstoykov force-pushed the basicNativeNativeBinaryProvisioning branch from 38432f1 to ca4a183 Compare October 24, 2025 15:54

mstoykov temporarily deployed to azure-trusted-signing October 24, 2025 16:01 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 24, 2025 16:02 — with GitHub Actions Inactive

mstoykov requested a review from codebien October 27, 2025 08:54

codebien reviewed Oct 27, 2025

View reviewed changes

internal/cmd/test_load.go Outdated Show resolved Hide resolved

Apply suggestions from code review

9649578

codebien previously approved these changes Oct 27, 2025

View reviewed changes

mstoykov temporarily deployed to azure-trusted-signing October 27, 2025 10:07 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 27, 2025 10:09 — with GitHub Actions Inactive

oleiade previously approved these changes Oct 28, 2025

View reviewed changes

internal/cmd/root.go Outdated Show resolved Hide resolved

internal/cmd/root.go Outdated Show resolved Hide resolved

Apply suggestions from code review

704b9c0

Co-authored-by: Théo Crevon <[email protected]>

mstoykov dismissed stale reviews from oleiade and codebien via 704b9c0 October 28, 2025 08:52

mstoykov requested review from codebien and oleiade October 28, 2025 08:52

mstoykov temporarily deployed to azure-trusted-signing October 28, 2025 08:58 — with GitHub Actions Inactive

mstoykov temporarily deployed to azure-trusted-signing October 28, 2025 09:00 — with GitHub Actions Inactive

oleiade approved these changes Oct 28, 2025

View reviewed changes

codebien approved these changes Oct 28, 2025

View reviewed changes

mstoykov merged commit 0b22245 into master Oct 28, 2025
40 checks passed

mstoykov deleted the basicNativeNativeBinaryProvisioning branch October 28, 2025 09:25

mstoykov added breaking change for PRs that need to be mentioned in the breaking changes section of the release notes area: Auto Extension Resolution Previously known as binary provisioning. labels Oct 30, 2025

	return deps, fmt.Errorf("already had a use directivce for %q", extension)
	return deps, fmt.Errorf("already had a use directive for %q", extension)

	type binaryIsNotSatisfyingDependenciesError struct {
	type binaryUnsatisfiedDependenciesError struct {

Refactor auto extension resolution to not use k6deps and esbuild #5320

Refactor auto extension resolution to not use k6deps and esbuild #5320

Uh oh!

Conversation

mstoykov commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

Checklist

Checklist: Documentation (only for k6 maintainers and if relevant)

Related PR(s)/Issue(s)

Uh oh!

mstoykov commented Oct 21, 2025

Uh oh!

codebien Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

mstoykov Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablochacin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codebien Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mstoykov commented Oct 17, 2025 •

edited

Loading